Avoid empty string for scope when inserting/updating #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Jan 16, 2023
Merged
…eplaces it with null Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/noid/oracle-empty-string
branch
from
8dd4d43
to
f940c03
Compare
|
Simpler and better now, right? |
juliusknorr
reviewed
Mar 10, 2023
lib/Db/Provider.php
Outdated
| #[\ReturnTypeWillChange] | ||
| public function jsonSerialize() { | ||
| return [ | ||
| 'id' => $this->id, | ||
| 'identifier' => $this->identifier, | ||
| 'clientId' => $this->clientId, | ||
| 'discoveryEndpoint' => $this->discoveryEndpoint, | ||
| 'scope' => $this->scope, | ||
| 'scope' => trim($this->scope), |
There was a problem hiding this comment.
Suggested change
| 'scope' => trim($this->scope), | |
| 'scope' => trim($this->getScope()), |
There was a problem hiding this comment.
Could also move the trim inside the getter then ;)
There was a problem hiding this comment.
Hmm I think we can't. It seems when updating/inserting a row in the DB, the value that is put there is accessed via the getter. So if we trim there, we will insert/update with an empty string which is what we want to avoid.
There was a problem hiding this comment.
Also, why do you think we should use the getter in jsonSerialize? For empty scopes, the getter will replace it by a space and then we trim it anyway.
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
juliusknorr
approved these changes
Mar 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because oracle replaces it with null.
We could do it differently by allowing null values for the scope column. Any preferred option?